Repository navigation
Add video properties to played intervals - #1
Merged
Merged
Conversation
Add width, height, codec and frame_rate_fps to representation_intervals, so that the record holds the inputs of a QoE model. Add frameRateFps to the content file and read it from the manifest in browser runs.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
width,height,codecandframe_rate_fpsto each entry ofrepresentation_intervals, so that QoE models can read them from the session record.The frame rate is new in the content file as
frameRateFps(30, as stated in the fixture manifests). Browser runs read it from the manifest.npm run verifypasses.